The war over Old Hickory’s legacy continues with a new biography that reminds us of his greatness—and why that is not the same as goodness.